d4x1 commented on code in PR #6338:
URL: 
https://github.com/apache/incubator-devlake/pull/6338#discussion_r1372708949


##########
backend/plugins/bitbucket/tasks/deployment_convertor.go:
##########
@@ -114,6 +114,7 @@ func ConvertDeployments(taskCtx plugin.SubTaskContext) 
errors.Error {
                                // So convert it to devlake's definition.
                                domainDeployCommit.Environment = devops.TESTING
                        }
+                       domainDeployCommit.CicdDeploymentId = 
domainDeployCommit.Id

Review Comment:
   CicdDeploymentId has a value in line 88. So I think there is no need to 
re-assign it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to