JorgeGar commented on PR #196:
URL: 
https://github.com/apache/incubator-devlake-helm-chart/pull/196#issuecomment-1781363689

   > > > @JorgeGar Do I need to also add the specific initContainer configs 
solution to #194 to this PR or leave it customizable as is?
   > > 
   > > 
   > > Hi @ProjectsOfMLee, you need to make so the default value generates the 
same result that you had before your change. I see in your commits this is what 
you did, so that’s perfect.
   > > A part from that, you do need to add the initContainert to the 
[HelmSetup.md](https://github.com/apache/incubator-devlake-helm-chart/blob/main/HelmSetup.md).
   > 
   > Thanks! I have added it to the .md
   
   Great! I’m checking with my phone, but it seems like the 
tabulation/number-of-spaces is different  from the rest. Could you kindly 
double-check and make sure it’s the same? It’s a silly thing, but it makes 
future reviews easier. The rest of the PR looks good to me 😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to