abeizn commented on code in PR #6535:
URL:
https://github.com/apache/incubator-devlake/pull/6535#discussion_r1410186177
##########
backend/plugins/webhook/api/deployments.go:
##########
@@ -36,18 +38,30 @@ import (
type WebhookDeployTaskRequest struct {
PipelineId string `mapstructure:"pipeline_id"`
// RepoUrl should be unique string, fill url or other unique data
- RepoId string `mapstructure:"repo_id"`
- RepoUrl string `mapstructure:"repo_url" validate:"required"`
- CommitSha string `mapstructure:"commit_sha" validate:"required"`
- RefName string `mapstructure:"ref_name"`
- Result string `mapstructure:"result"`
+ RepoId string `mapstructure:"repo_id"`
+ Result string `mapstructure:"result"`
// start_time and end_time is more readable for users,
// StartedDate and FinishedDate is same as columns in db.
// So they all keep.
CreatedDate *time.Time `mapstructure:"create_time"`
StartedDate *time.Time `mapstructure:"start_time" validate:"required"`
FinishedDate *time.Time `mapstructure:"end_time"`
+ RepoUrl string `mapstructure:"repo_url"`
Environment string `validate:"omitempty,oneof=PRODUCTION STAGING
TESTING DEVELOPMENT"`
Review Comment:
This will not change the name, it will be resolved into **_environment_**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
