d4x1 commented on code in PR #6686:
URL: 
https://github.com/apache/incubator-devlake/pull/6686#discussion_r1434066665


##########
backend/plugins/zentao/models/connection.go:
##########
@@ -106,6 +107,31 @@ func (connection ZentaoConnection) Sanitize() 
ZentaoConnection {
        return connection
 }
 
+// Merge works with the new connection helper.
+func (connection ZentaoConnection) Merge(existed, modified *ZentaoConnection) 
error {
+       existedDBUrl := existed.DbUrl

Review Comment:
   @abeizn 
   I am afraid not. If modified db url is something like 
`username:*****@ip:port/db_name`, it means there is no update with db url 
field, and we should use the value in database.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to