d4x1 commented on PR #6689: URL: https://github.com/apache/incubator-devlake/pull/6689#issuecomment-1868902828
IMO, there is one question I think we should disscuss: BitBucket Cloud and BitBucket Server are regarded as one some type connection in the ConfigUI(you can see the config form for BitBucket), so I don't think it should be a sperated plugin with sperated go package(in a seperate directory). GitHub Connection supports cloud and server version at the same time. <img width="804" alt="image" src="https://github.com/apache/incubator-devlake/assets/5844806/571ffb71-7292-4b43-b790-03849736b181";> BitBucket is designed like GitHub. <img width="813" alt="image" src="https://github.com/apache/incubator-devlake/assets/5844806/799decff-7ef7-4ac1-9485-6139b48756fc";> And in this way, we can reduce lots of duplicated codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
