keon94 commented on PR #6701: URL: https://github.com/apache/incubator-devlake/pull/6701#issuecomment-1872667162
My thoughts: - I think `GitRepo` should be turned into an interface with two impls: GoGitRepo and LibGitRepo. Refactor the appropriate methods. - Instead of writing CSV files for testing, I'd create a test suite where each test case calls the functions on the GitRepo interface for the two implementations mentioned above. Compare the results of the function calls and make sure they are identical. The above approach should lead to cleaner and more abstract code that is not so tied to a library's implementation. And it'll allow us to seemlessly support both libraries until we decide to remove libgit later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
