d4x1 commented on code in PR #7032: URL: https://github.com/apache/incubator-devlake/pull/7032#discussion_r1504143274
########## backend/python/pydevlake/pydevlake/model.py: ########## @@ -125,13 +128,17 @@ def set_tool_origin(self, tool_model: 'ToolModel'): class NoPKModel(RawDataOrigin): - created_at: Optional[datetime] = Field( + created_at: [datetime] = Field( Review Comment: I want to remove `Optional` in `created_at` to solve problems like this: 1. collect and store data in domain layers' tables with `created_at` = some value. 2. collect and store data again, then new `yield` data with `created_at` = None will make records in database tables `created_at` = `NULL`. (it works during `session.merge()`) So I cannot remove `Optional` in `created_at`. Do you have ideas about how to solve this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
