This is an automated email from the ASF dual-hosted git repository.

abeizn pushed a commit to branch fix#7091
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/fix#7091 by this push:
     new f1ea31ce9 fix: sonarqube test connection can not effective
f1ea31ce9 is described below

commit f1ea31ce9b14361fc03a129d6c66fbc9fbc92125
Author: abeizn <[email protected]>
AuthorDate: Tue Mar 5 16:52:26 2024 +0800

    fix: sonarqube test connection can not effective
---
 backend/plugins/sonarqube/api/connection_api.go | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/backend/plugins/sonarqube/api/connection_api.go 
b/backend/plugins/sonarqube/api/connection_api.go
index 29f26370c..796e62c68 100644
--- a/backend/plugins/sonarqube/api/connection_api.go
+++ b/backend/plugins/sonarqube/api/connection_api.go
@@ -19,6 +19,7 @@ package api
 
 import (
        "context"
+       "fmt"
        "net/http"
 
        "github.com/apache/incubator-devlake/core/errors"
@@ -116,6 +117,10 @@ func TestExistingConnection(input 
*plugin.ApiResourceInput) (*plugin.ApiResource
        if testConnectionErr != nil {
                return nil, plugin.WrapTestConnectionErrResp(basicRes, 
testConnectionErr)
        }
+       if testConnectionResult.Status != http.StatusOK {
+               errMsg := fmt.Sprintf("Test connection fail, unexpected status 
code: %d", testConnectionResult.Status)
+               return nil, plugin.WrapTestConnectionErrResp(basicRes, 
errors.Default.New(errMsg))
+       }
        return &plugin.ApiResourceOutput{Body: testConnectionResult, Status: 
http.StatusOK}, nil
 }
 

Reply via email to