klesh commented on code in PR #7820:
URL:
https://github.com/apache/incubator-devlake/pull/7820#discussion_r1701370026
##########
backend/plugins/circleci/tasks/shared.go:
##########
@@ -121,3 +121,12 @@ func ParseCircleciPageTokenResp(res *http.Response)
([]json.RawMessage, errors.E
err := api.UnmarshalResponse(res, &data)
return data.Items, err
}
+
+func ignoreDeletedBuilds(res *http.Response) errors.Error {
+ // CircleCI API will return a 404 response for a workflow/job that has
been deleted
+ // due to their data retention policy. We should ignore these errors.
+ if res.StatusCode == http.StatusNotFound {
+ return api.ErrIgnoreAndContinue
Review Comment:
Shouldn't it be `api.ErrFinishCollect` ? There would be no more data to be
collected if the reason was "data retention", would it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
