Nickcw6 opened a new pull request, #7910:
URL: https://github.com/apache/incubator-devlake/pull/7910
### Summary
Fixes bug whereby CircleCI deployments matching job name were not pulling
through to `cicd_deployments`.
This was due to the `job_converter` setting `pipeline_id` as the UUID of the
CircleCI pipeline on `cicd_tasks`. The query to generate `cicd_deployments`
attempts to join this column onto the `id` of `cicd_pipelines` - which is in
the format `circleci:CircleciWorkflow:1:{workflow_id}`. Updating the value of
`pipeline_id` on `cicd_task` resolved the issue.
Also updated relevant tests & changed the name of the relevant IdGen
function in the plugin -> `getWorkflowIdGen`.
Retransforming the data after merge will fix the issue.
### Does this close any open issues?
Closes #7889
### Screenshots
Before:
2 deployments in `cicd_tasks`
<img width="954" alt="Screenshot 2024-08-16 at 16 48 39"
src="https://github.com/user-attachments/assets/b5e2bbfa-64ed-4800-b75f-116dfd61e702";>
Nothing in `cicd_deployments`
<img width="447" alt="Screenshot 2024-08-16 at 16 50 54"
src="https://github.com/user-attachments/assets/423bdb9b-abce-4ca5-bf30-8c5f171bcf6c";>
Nothing in `cicd_deployment_commits`
<img width="615" alt="Screenshot 2024-08-16 at 16 52 00"
src="https://github.com/user-attachments/assets/d8d5f428-4074-4c70-8eff-5285053f89f9";>
After:
<img width="965" alt="Screenshot 2024-08-16 at 16 54 16"
src="https://github.com/user-attachments/assets/162828e7-b381-44d4-9d40-ffe4fc9deff0";>
`cicd_deployments`:
<img width="683" alt="Screenshot 2024-08-16 at 16 54 36"
src="https://github.com/user-attachments/assets/8ed32726-b347-4d10-9f0d-2685aac755ec";>
`cicd_deployment_commits`:
<img width="784" alt="Screenshot 2024-08-16 at 16 54 55"
src="https://github.com/user-attachments/assets/6121c67b-025f-47d2-8158-a7faa6f1f44b";>
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
