ktoublanc commented on PR #8000:
URL: 
https://github.com/apache/incubator-devlake/pull/8000#issuecomment-2342960456

   > LGTM. Don't forget to write a migration script to add the column to the 
database.
   
   Hey, thanks for the review.
   
   I don't get what migration script I should write...
   From my point of view, I'm only adding a field in the Webhook API which will 
value the Url field of the deployment model.
   This field is already created in the database (cicd_deployments.url) which 
is nullable and I can't set a default value for the field and there are no 
associated _tool_webhook_... table associated.
   
   Am I getting it right ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@devlake.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to