Nickcw6 commented on PR #7986: URL: https://github.com/apache/incubator-devlake/pull/7986#issuecomment-2358864824
@klesh Thanks! I have pushed a small refactor commit. Re: unfinished jobs - not sure I necessarily agree in this case. I'm not super familiar with other CI platforms but jobs in CircleCI are often statistically significant & not always that quick; in our case e.g. we have some relatively long running build jobs, and some of our deployment matchers are configured to look for a specific `deploy-to-prod` job. We definitely want to ensure these are collected at some point. To ensure we still collect these, whilst not collecting unfinished jobs, we'd need to: - Add the logic to exclude any unfinished jobs - Check for unfinished workflows instead of unfinished jobs 100% agree we should be as aligned as possible but IMO this adds more complexity than the current approach of just collecting everything & recollecting any unfinished jobs... Unless I am missing something - open to suggestions :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
