JorgeGar commented on code in PR #320:
URL:
https://github.com/apache/incubator-devlake-helm-chart/pull/320#discussion_r1969375649
##########
charts/devlake/charts/grafana/templates/_pod.tpl:
##########
@@ -1134,17 +1134,20 @@ volumes:
{{- toYaml .csi | nindent 6 }}
{{- end }}
{{- end }}
- {{- range .Values.extraVolumeMounts }}
+ {{- range .Values.extraVolumes }}
- name: {{ .name }}
{{- if .existingClaim }}
persistentVolumeClaim:
claimName: {{ .existingClaim }}
{{- else if .hostPath }}
hostPath:
- path: {{ .hostPath }}
+ {{ toYaml .hostPath | nindent 6 }}
Review Comment:
Is this change also related to the issue with the volume mount?
##########
charts/devlake/charts/grafana/templates/_pod.tpl:
##########
@@ -1134,17 +1134,20 @@ volumes:
{{- toYaml .csi | nindent 6 }}
{{- end }}
{{- end }}
- {{- range .Values.extraVolumeMounts }}
+ {{- range .Values.extraVolumes }}
- name: {{ .name }}
{{- if .existingClaim }}
persistentVolumeClaim:
claimName: {{ .existingClaim }}
{{- else if .hostPath }}
hostPath:
- path: {{ .hostPath }}
+ {{ toYaml .hostPath | nindent 6 }}
{{- else if .csi }}
csi:
{{- toYaml .data | nindent 6 }}
+ {{- else if .configMap }}
+ configMap:
+ {{- toYaml .configMap | nindent 6 }}
Review Comment:
Same question as before 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
