kahirokunn commented on PR #337: URL: https://github.com/apache/incubator-devlake-helm-chart/pull/337#issuecomment-3043879897
Hi @klesh – thanks again for the review! TL;DR : the change is backward-compatible, so we don’t need a compatibility shim or extra docs. Topic Explanation Breaking change? No. I’ve tested upgrades from the current chart to this branch in two scenarios:1. option.autoCreateSecret=true (default) – the upgrade is seamless.2. User-supplied Secret – the pod now receives duplicate env-vars with identical values; Kubernetes starts the container without error. Compatibility layer? Not needed. Both upgrade paths above work out-of-the-box. Docs update? The existing docs remain accurate: they already describe option.autoCreateSecret and custom-Secret workflows, which continue to work unchanged. If you’d still prefer a brief “no action required” note in the website repo, just let me know and I’ll add it. Otherwise I think the chart can ship as-is. Thanks for confirming! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@devlake.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
