carocad opened a new pull request, #8522:
URL: https://github.com/apache/incubator-devlake/pull/8522

   ### Summary
   
   Allow having an idle connection value of 0 or less as this is supported by 
the SQL driver documented 
[here](https://gorm.io/docs/connecting_to_the_database.html#Connection-Pool) 
which points [here](https://pkg.go.dev/database/sql#DB.SetMaxIdleConns).
   
   ### Does this close any open issues?
   
   No
   
   ### Other Information
   
   In my setup we are using AWS Aurora Serverless v2. One important property of 
this technology is that it automatically scales the cluster depending on load. 
It can scale down to 0 and then we don't pay for the use of the database; which 
we want in order to save money. 
   
   Unfortunately devlake doesn't allow having less than 1 idle connection. This 
PR fixes that by removing the condition from the code and relying on the SQL 
driver to manage the connection pooling.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@devlake.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to