GoSimplicity commented on PR #8601: URL: https://github.com/apache/incubator-devlake/pull/8601#issuecomment-3385968083
> After reading issue #8579, could the problem be that `scope_api.go` and `remote_api.go` are returning incorrect scopes? Thanks for the review I checked both `remote_api.go` and `scope_api.go`. You're right to question this. From what I can see: - `remote_api.go` looks fine - MultiBranchProject is treated as a scope (it's in `scopesWithJobs`), so its branch jobs won't show up as selectable scopes in the UI - The issue in #8579 is different - when you select a MultiBranchProject, the collector grabs all branch jobs underneath it, converts them to `cicd_pipelines`, and they all show up in Grafana My PR filters branches during collection so only matching ones get into Grafana. But you're right that we should check if `GetScopeList` is also returning these auto-collected branch jobs alongside user-selected scopes. Should I add logic to distinguish user-selected scopes from auto-collected branch jobs? Or is filtering at collection time enough for this use case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
