petkostas commented on PR #8527:
URL:
https://github.com/apache/incubator-devlake/pull/8527#issuecomment-3386636279
> Hi @klesh and @netvetra!
>
> We are also experiencing issues with to obtain SonarQube projects' list
due to not user permissions and just came across with this PR. I have seen your
changes and we are waiting for this PR to be merged to deploy a new image for
our Devlake application. I wanted to confirm, should not we also make the
change below in remote_api.go:
>
> ```
> if page.Page == 0 {
> page.Page = 1
> }
> res, err := apiClient.Get("components/search", url.Values{
> "p": {fmt.Sprintf("%v", page.Page)},
> "ps": {fmt.Sprintf("%v", page.PageSize)},
> "q": {keyword},
> "qualifiers": {"TRK"},
> }, nil)
> if err != nil {
> return
> }
> ```
Please don't hardcode values like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
