mieliespoor commented on code in PR #8611:
URL:
https://github.com/apache/incubator-devlake/pull/8611#discussion_r2469564741
##########
backend/server/api/router.go:
##########
@@ -93,6 +93,16 @@ func RegisterRouter(r *gin.Engine, basicRes
context.BasicRes) {
}
// mount all api resources for all plugins
for pluginName, apiResources := range resources {
+ if pluginName == "webhook" {
Review Comment:
Not exactly a conflict, but more a duplicate route not wanted. The way
routing is done, this route, because how it is defined on the plugin, would
have resulted in the route `/plugins/webhook/projects/:projectName/deployments`
instead of only `/projects/:projectName/deployments`. With this we now only
have the latter as we remove the registration of the route on the webhook
plugin route. Best way I could think of achieving this, unless the code is
moved elsewhere and not in the plugin itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
