amnir opened a new pull request, #8645:
URL: https://github.com/apache/incubator-devlake/pull/8645

   <!--
   Licensed to the Apache Software Foundation (ASF) under one or more
   contributor license agreements.  See the NOTICE file distributed with
   this work for additional information regarding copyright ownership.
   The ASF licenses this file to You under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
   -->
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   
   ### Summary
   Make config-ui dev server accessible outside the container when started by 
listening on 0.0.0.0 with the --host flag.
   Also ensure it uses port 4000 or fails to start with --strictPort to prevent 
silent port change that will mismatch with the exported dev container port.
   
   In addition, it makes Grafana accessible from dev container' config-ui by 
making the Grafana origin and origin change configurable and injected via the 
dev container environment variables.
   
   web socket proxying (ws) is enabled regardless of dev container or not as it 
allows for features like grafana query auto-complete to work via the dev server 
proxy.
   
   ### Does this close any open issues?
   Closes [#8638](https://github.com/apache/incubator-devlake/issues/8638)
   
   ### Other Information
   Re-opened as a new PR to better comply with the contribution guidelines 
(branch name + commit message)
   ([Initial PR](https://github.com/apache/incubator-devlake/pull/8639))
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to