piatroumaxim opened a new pull request, #362:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/362
## What changes were introduced?
- Added a new configurable `clusterDomain` parameter to `values.yaml` with
default value `cluster.local`
- Replaced all hardcoded occurrences of `cluster.local` with `{{
.Values.clusterDomain }}` in Helm templates
- Updated relevant documentation (HelmSetup.dm)
## Why is this change needed?
Currently, the Helm chart contains hardcoded `cluster.local` references
which makes it incompatible with Kubernetes clusters using different cluster
domains (e.g., OpenShift, RKE, custom installations). This change adds
flexibility while maintaining full backward compatibility.
## Key features:
- **Backward compatible**: Default value remains `cluster.local` – existing
installations unaffected
- **Configurable**: Users can now specify custom cluster domains via values
- **Standards-aligned**: Uses common Kubernetes terminology (`clusterDomain`)
## Usage example:
```yaml
# Custom cluster domain
clusterDomain: "internal.k8s.local"
# Or use default
# clusterDomain: "cluster.local"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
