Ke-vin-S commented on code in PR #8791:
URL:
https://github.com/apache/incubator-devlake/pull/8791#discussion_r3049223521
##########
backend/plugins/github_graphql/impl/impl.go:
##########
@@ -230,8 +189,8 @@ func (p GithubGraphql) PrepareTaskData(taskCtx
plugin.TaskContext, options map[s
return 0, nil,
errors.Default.Wrap(dataErrors[0], `query rate limit fail`)
}
if query.RateLimit == nil {
- logger.Info(`github graphql rate limit are
disabled, fallback to 5000req/hour`)
- return 5000, nil, nil
+ logger.Info(`github graphql rate limit
unavailable, using fallback rate limit`)
+ return 0, nil, errors.Default.New("rate limit
unavailable")
Review Comment:
Changed the Warn logs as Info logs. but kept the error here so the handling
is centralized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
