techdecline opened a new pull request, #8839:
URL: https://github.com/apache/incubator-devlake/pull/8839

   …-broken builds
   
   Builds that fail due to YAML syntax errors in pipeline definitions return an 
empty or non-JSON body from the Timeline API (200 OK with no usable content). 
Previously this caused ParseRawMessageFromRecords to propagate a hard error 
that aborted the entire collectApiTimelineRecords subtask.
   
   Two complementary fixes:
   
   1. Add ignoreInvalidTimelineResponse AfterResponse handler that supersedes 
ignoreDeletedBuilds: it still skips 404s (deleted builds) and now also skips 
responses with empty or non-JSON bodies by returning api.ErrIgnoreAndContinue, 
leaving the rest of the pipeline intact. The body is peeked and then restored 
via io.NopCloser so the downstream ResponseParser can still read it when the 
body is valid JSON.
   
   2. Extend the DB query in CollectRecords to exclude builds with result = 
'none' in addition to result = 'failed'. Builds broken by YAML syntax errors 
are categorised as 'none' by Azure DevOps (already mapped to RESULT_FAILURE in 
cicdBuildResultRule), so fetching their timeline is both unnecessary and the 
primary source of the bad responses. Using NOT IN ? with a []string slice 
follows the same pattern used in blueprint_helper.go.
   
   Unit tests added for ignoreInvalidTimelineResponse covering: 404, empty 
body, non-JSON body, valid JSON (nil error + body restored), and valid empty 
JSON object.
   
   Fixes: #8838
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one or more
   contributor license agreements.  See the NOTICE file distributed with
   this work for additional information regarding copyright ownership.
   The ASF licenses this file to You under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
   -->
   ### ⚠️ Pre Checklist
   
   > Please complete _ALL_ items in this checklist, and remove before submitting
   
   - [ ] I have read through the [Contributing 
Documentation](https://devlake.apache.org/community/).
   - [ ] I have added relevant tests.
   - [ ] I have added relevant documentation.
   - [ ] I will add labels to the PR, such as `pr-type/bug-fix`, 
`pr-type/feature-development`, etc.
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   
   ### Summary
   What does this PR do?
   
   ### Does this close any open issues?
   Closes xx
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to