This is an automated email from the ASF dual-hosted git repository.
Startrekzky pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new c413ebc6c fix(asana): implement encryption for Asana connection token
(#8873)
c413ebc6c is described below
commit c413ebc6c514f3ce17b40bbf17d0b1cfa09b320c
Author: Klesh Wong <[email protected]>
AuthorDate: Sun May 17 17:13:55 2026 +0800
fix(asana): implement encryption for Asana connection token (#8873)
---
backend/plugins/asana/models/connection.go | 2 +-
.../20260509000001_encrypt_connection_token.go | 82 ++++++++++++++++++++++
.../asana/models/migrationscripts/register.go | 1 +
3 files changed, 84 insertions(+), 1 deletion(-)
diff --git a/backend/plugins/asana/models/connection.go
b/backend/plugins/asana/models/connection.go
index ecd49f1aa..349a69bcc 100644
--- a/backend/plugins/asana/models/connection.go
+++ b/backend/plugins/asana/models/connection.go
@@ -29,7 +29,7 @@ import (
// AsanaConn holds the essential information to connect to the Asana API
type AsanaConn struct {
helper.RestConnection `mapstructure:",squash"`
- Token string `mapstructure:"token" json:"token"
encrypt:"yes"`
+ Token string `mapstructure:"token" json:"token"
gorm:"serializer:encdec"`
}
func (ac *AsanaConn) Sanitize() AsanaConn {
diff --git
a/backend/plugins/asana/models/migrationscripts/20260509000001_encrypt_connection_token.go
b/backend/plugins/asana/models/migrationscripts/20260509000001_encrypt_connection_token.go
new file mode 100644
index 000000000..6a67eacee
--- /dev/null
+++
b/backend/plugins/asana/models/migrationscripts/20260509000001_encrypt_connection_token.go
@@ -0,0 +1,82 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package migrationscripts
+
+import (
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/dal"
+ "github.com/apache/incubator-devlake/core/errors"
+ "github.com/apache/incubator-devlake/core/plugin"
+)
+
+type asanaConnectionTokenPlain struct {
+ ID uint64 `gorm:"primaryKey"`
+ Token string
+}
+
+func (asanaConnectionTokenPlain) TableName() string {
+ return "_tool_asana_connections"
+}
+
+type encryptConnectionToken struct{}
+
+func (*encryptConnectionToken) Up(basicRes context.BasicRes) errors.Error {
+ db := basicRes.GetDal()
+ encKey := basicRes.GetConfig(plugin.EncodeKeyEnvStr)
+ if encKey == "" {
+ return errors.BadInput.New("asana invalid encKey")
+ }
+
+ cursor, err := db.Cursor(dal.From(&asanaConnectionTokenPlain{}))
+ if err != nil {
+ return err
+ }
+ defer cursor.Close()
+
+ for cursor.Next() {
+ row := &asanaConnectionTokenPlain{}
+ if err = db.Fetch(cursor, row); err != nil {
+ return err
+ }
+ if row.Token == "" {
+ continue
+ }
+ encryptedToken, err := plugin.Encrypt(encKey, row.Token)
+ if err != nil {
+ return err
+ }
+ err = db.UpdateColumns(
+ row.TableName(),
+ []dal.DalSet{{ColumnName: "token", Value:
encryptedToken}},
+ dal.Where("id = ?", row.ID),
+ )
+ if err != nil {
+ return err
+ }
+ }
+
+ return nil
+}
+
+func (*encryptConnectionToken) Version() uint64 {
+ return 20260509000001
+}
+
+func (*encryptConnectionToken) Name() string {
+ return "encrypt asana connection token"
+}
diff --git a/backend/plugins/asana/models/migrationscripts/register.go
b/backend/plugins/asana/models/migrationscripts/register.go
index 9d25d2ed5..753f19262 100644
--- a/backend/plugins/asana/models/migrationscripts/register.go
+++ b/backend/plugins/asana/models/migrationscripts/register.go
@@ -30,5 +30,6 @@ func All() []plugin.MigrationScript {
new(addTaskTransformationFields),
new(addScopeConfigIssueTypeFields),
new(addConnectionIdToAsanaScopeConfigs),
+ new(encryptConnectionToken),
}
}
