klesh commented on PR #8882:
URL: 
https://github.com/apache/incubator-devlake/pull/8882#issuecomment-4581800932

   > Hi @klesh , I noticed the `check-grafana-dashboards` CI action is failing 
because it flags the object form `{"type": "mysql", "uid": "mysql"}` which I 
added as part of the Grafana v13 compatibility fix. Could you please take a 
look and let me know if I am missing something or if the CI check needs to be 
updated alongside this PR?
   > 
   > Also since this is a major version upgrade, there may be edge cases or 
community-facing features that rely on the older Grafana version that I might 
have missed. A thorough review from the team would be really appreciated.
   > 
   > Thank you!
   
   I think you need to update 
https://github.com/apache/incubator-devlake/blob/main/.github/workflows/grafana-dashboards-check.yml#L34
 to reflect the new syntax.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to