JAORMX commented on code in PR #8894: URL: https://github.com/apache/devlake/pull/8894#discussion_r3397820188
########## backend/plugins/github/e2e/snapshot_tables/account.csv: ########## @@ -1,8 +1,9 @@ id,email,full_name,user_name,avatar_url,organization,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark -github:GithubAccount:1:1052632,runner.mei@,runner,runner-mei,https://avatars.githubusercontent.com/u/1052632?v=4,,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_accounts,13, -github:GithubAccount:1:21979,[email protected],Bo-Yi Wu,appleboy,https://avatars.githubusercontent.com/u/21979?v=4,"COSCUP,nodejs-tw,moztw,h5bp,CodeIgniter-TW,drone,Getmore,golangtw,laravel-taiwan,go-xorm,gin-gonic,PHPConf-TW,Mediatek-Cloud,SJFinder,go-gitea,laradock,gin-contrib,tagfans,maintainers,go-training,go-ggz,the-benchmarker,golang-queue","{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_accounts,8, -github:GithubAccount:1:3794113,[email protected],Derek,shanhuhai5739,https://avatars.githubusercontent.com/u/3794113?v=4,,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_accounts,2, -github:GithubAccount:1:3971390,[email protected],ppmoon,ppmoon,https://avatars.githubusercontent.com/u/3971390?v=4,,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_accounts,14, -github:GithubAccount:1:7496278,[email protected],Andy Pan,panjf2000,https://avatars.githubusercontent.com/u/7496278?v=4,,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_accounts,5, -github:GithubAccount:1:8518239,[email protected],The Gitter Badger,gitter-badger,https://avatars.githubusercontent.com/u/8518239?v=4,,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_accounts,9, -github:GithubAccount:1:964542,[email protected],Sarath Sadasivan Pillai,sarathsp06,https://avatars.githubusercontent.com/u/964542?v=4,"exotel,leadmrktr,shellagilehub,odysseyhack,boodltech","{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_accounts,1, +github:GithubAccount:1:1052632,runner.mei@,runner,runner-mei,https://avatars.githubusercontent.com/u/1052632?v=4,,,,0, Review Comment: Done in b67aad764! The converter now carries the _raw_data fields over: it prefers the enriched _tool_github_accounts row when we collected a profile, and falls back to the _tool_github_repo_accounts row for the non-committer case (that's why milichev shows _raw_github_api_issues provenance). The e2e fixture was missing the _raw_data columns too, so I added those and regenerated the snapshot... the enriched rows now carry exactly the same provenance as before this PR. While at it, I also guarded pr_convertor.go against generating account ids for a zero AuthorId/MergedById. An unmerged PR would otherwise get merged_by_id pointing at github:GithubAccount:1:0, which is the same orphan shape this PR is fixing (issue_convertor already had that guard). Verified the full github e2e suite on both MySQL and PostgreSQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
