bujjibabukatta commented on PR #8922: URL: https://github.com/apache/devlake/pull/8922#issuecomment-4698922442
Hi @albusshirazi Thanks for the feedback. You're right — the ternary expression was effectively redundant since both branches returned the same data. I've removed the unnecessary ternary and the showAll dependency from the memo. The filtering logic is already handled server-side in useRefreshData, which switches between listAll and list based on the value of showAll, so no additional client-side filtering is required here. I've pushed the changes. Could you please take another look and let me know if everything looks good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
