bujjibabukatta opened a new pull request, #8959:
URL: https://github.com/apache/devlake/pull/8959
When running incremental collection, GetMergeRequestsIterator filters merge
requests using gitlabupdatedat > since.
When running incremental collection, GetMergeRequestsIterator filters merge
requests using gitlab_updated_at > since. This works fine for notes and reviews
— if the MR hasn't been touched, nothing new to collect. But for commits it's
the wrong filter. Pushing new commits to a MR's source branch doesn't update
gitlab_updated_at on the MR itself, so those MRs get skipped entirely and their
new commits are never fetched. This is exactly why full refresh works but
normal collect misses data.
The fix is to pass nil instead of apiCollector when calling
GetMergeRequestsIterator in the commit collector. Passing nil skips the time
filter so every MR is scanned for commits on each run, matching full refresh
behaviour. The MR commits endpoint is lightweight so the performance impact is
minimal. Notes and reviews collectors are unchanged — they still pass
apiCollector and keep their incremental filtering, which is correct for those
entities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
