klesh commented on PR #9026: URL: https://github.com/apache/devlake/pull/9026#issuecomment-5163170941
> Thanks @klesh — I've pushed the `env.example` entry with a comment explaining the behaviour. > > On the status code: unfortunately it can't distinguish these, because the failing pages arrive with a _successful_ status. `HttpMinStatusRetryCode` is `http.StatusBadRequest` (`helpers/pluginhelper/api/api_async_client.go`), so anything >= 400 is retried and then surfaced as an error before `ResponseParser` is ever called. By the time the parser runs, the response is already < 400 — typically a plain 200 whose body is a truncated payload or an HTML error page substituted by a proxy. The status line says success; only the body reveals the problem, which is why the check has to sit at the parse step rather than on the status code. > > That is also why the flag is deliberately narrow: HTTP error statuses keep their existing retry behaviour and are unaffected by it. Thanks for the explanation. I appreciate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
