DoDiODev commented on PR #9028: URL: https://github.com/apache/devlake/pull/9028#issuecomment-5168736554
Could a maintainer please approve the workflow runs for this PR? They are currently sitting in `action_required`. One heads-up so the result is not misread: **the Go jobs will fail even after approval**, and not because of this change. They run inside `mericodev/lake-builder:latest`, which still ships libgit2 1.3.2 (and Go 1.20.4), so git2go v34 cannot compile there: ``` git2go/[email protected]/Build_system_dynamic.go:12:3: error: #error "Invalid libgit2 version; this git2go supports libgit2 between v1.5.0 and v1.5.0" ``` That image can only be republished by a maintainer (`build-builder.yml`, triggered by a `builder-*` tag). The two extra commits in this PR fix `devops/docker/lake-builder/Dockerfile`, which is currently unbuildable on `main` regardless of this change (`golang:1.26-bullseye` was never published, and the libgit2 cmake step needs a Python interpreter for tests we never build). To show the change itself is sound, the identical job matrix was run in a fork workflow that builds the lake-builder image from this branch and runs every Go job inside it: **8/8 green** — https://github.com/DoDiODev/devlake/actions/runs/30828741519 (builder image, golangci-lint, unit-test, e2e/MySQL, migration-script-lint, config-ui, ASF license header, Grafana dashboards). Happy to split the two Dockerfile fixes into a separate, earlier PR if that makes the rollout easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
