danielemoraschi commented on PR #8946:
URL: https://github.com/apache/devlake/pull/8946#issuecomment-5182189092

   Closing this as superseded by #9027, which landed on `main` in 5eee167.
   
   That change covers the same root cause. The LEFT JOIN against the raw table
   yields a NULL `data` column for a domain row whose `_raw_data_id` no longer 
has
   a matching raw record, and that value fell through to `default: return nil`,
   ending the scan. #9027 also goes further than this PR did:
   
   * @klesh's review note is addressed there. `extractCustomizedFields` returns 
the
     number of orphaned rows, and `ExtractCustomizedFields` logs a warning 
naming
     the table, the raw table, and the count.
   * `rows.Err()` is now returned at the end of the scan, so an error raised 
while
     iterating the cursor is no longer discarded. That is the same class of 
silent
     partial processing this PR left in place.
   * Test coverage is broader: skipping an orphan and continuing, every row
     orphaned, no orphans at all, and a cancelled context. This PR had one
     regression test.
   
   Nothing in this branch is additive on top of that, so there is no point in
   rebasing. Thanks @klesh for the review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to