Tugrulhankars commented on PR #9014: URL: https://github.com/apache/devlake/pull/9014#issuecomment-5265211628
> > Hi @klesh 👋 > > I've cleaned up this PR significantly: > > Rebased on latest main, all conflicts resolved Reduced PR scope from ~40 files to 25 (removed unrelated changes like yarn.lock, docker-compose rename, Windows stubs, static plugin registration) Translated all comments to English, removed debug code Added 12 unit tests covering Cloud and On-Premises scenarios (all passing) Fixed a bug where remote scopes used a hardcoded VSSPS URL that doesn't work for On-Premises Could someone please approve the CI workflows? Happy to address any review feedback. Thank you! > > Good work. Please fix the golint error and i will take look. > > Hi @klesh 👋 > > I've cleaned up this PR significantly: > > Rebased on latest main, all conflicts resolved Reduced PR scope from ~40 files to 25 (removed unrelated changes like yarn.lock, docker-compose rename, Windows stubs, static plugin registration) Translated all comments to English, removed debug code Added 12 unit tests covering Cloud and On-Premises scenarios (all passing) Fixed a bug where remote scopes used a hardcoded VSSPS URL that doesn't work for On-Premises Could someone please approve the CI workflows? Happy to address any review feedback. Thank you! > > Good work. Please fix the golint error and i will take look. Thanks @klesh! I've fixed all the issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
