bramhanandlingala commented on PR #9045: URL: https://github.com/apache/devlake/pull/9045#issuecomment-5271103126
Hi @klesh, thanks so much for reviewing this! Just to clarify the scope of the change — the diff only removes the two lines that copied collectorState.LatestSuccessStart into PrevStartedAt. Everything else stays the same, so incremental mode still works normally after the first run: Close() saves PrevStartedAt, and the next run picks it up and goes incremental as before. It's only the very first run that behaves differently now — it does a proper full sync instead of being mistaken for a run that already happened. On the _tool_github_runs idea — I think we might run into the same issue there. The extractor writes to that table just before the converter runs, in the same pipeline, so on a genuine first run it would already have data too, and we could end up dropping the backlog again the same way. Let me know your thoughts, and happy to adjust if I'm missing something on your end! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
