TOGEP commented on code in PR #380:
URL:
https://github.com/apache/devlake-helm-chart/pull/380#discussion_r3819046133
##########
charts/devlake/templates/deployments.yaml:
##########
@@ -86,15 +87,15 @@ spec:
{{- end }}
env:
- name: DEVLAKE_ENDPOINT
- value: {{ include "devlake.fullname" . }}-lake.{{
.Release.Namespace }}.svc.cluster.local:8080
+ value: {{ include "devlake.fullname" . }}-lake.{{
.Release.Namespace }}.svc.cluster.local:{{ .Values.lake.port }}
Review Comment:
`lake.port` was already configurable, but this endpoint still used the
hard-coded port `8080`.
As a result, changing `lake.port` did not work end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
