This is an automated email from the ASF dual-hosted git repository.
klesh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 9de8a09a7 fix(argocd): add CICD DomainTypes to application
collect/extract subtasks (#9080)
9de8a09a7 is described below
commit 9de8a09a7c034b065622625d416ac3dd128e9bd0
Author: sanscfs <[email protected]>
AuthorDate: Sat Sep 5 09:40:06 2026 +0300
fix(argocd): add CICD DomainTypes to application collect/extract subtasks
(#9080)
collectApplications and extractApplications had no DomainTypes, while the
convertApplications / *SyncOperations subtasks carry DomainTypes [CICD].
Blueprint plan generation (MakePipelinePlanSubtasks) only includes a
subtask whose DomainTypes intersect the scope config's entities (typically
["CICD"]). With no DomainTypes, the application subtasks were never
generated into the blueprint plan, so
_tool_argocd_applications.dest_namespace
was never populated and detectEnvironment() classified every ArgoCD
deployment as TESTING instead of PRODUCTION.
Add DomainTypes: [CICD] so the application collect/extract subtasks are
generated alongside the sync-operation ones, letting dest_namespace populate
natively.
Co-authored-by: sanscfs <[email protected]>
Co-authored-by: Claude Fable 5 <[email protected]>
Co-authored-by: Klesh Wong <[email protected]>
---
backend/plugins/argocd/tasks/application_collector.go | 1 +
backend/plugins/argocd/tasks/application_extractor.go | 1 +
2 files changed, 2 insertions(+)
diff --git a/backend/plugins/argocd/tasks/application_collector.go
b/backend/plugins/argocd/tasks/application_collector.go
index 133f4188a..b109541ac 100644
--- a/backend/plugins/argocd/tasks/application_collector.go
+++ b/backend/plugins/argocd/tasks/application_collector.go
@@ -37,6 +37,7 @@ var CollectApplicationsMeta = plugin.SubTaskMeta{
EntryPoint: CollectApplications,
EnabledByDefault: true,
Description: "Collect applications from ArgoCD API",
+ DomainTypes: []string{plugin.DOMAIN_TYPE_CICD},
}
func CollectApplications(taskCtx plugin.SubTaskContext) errors.Error {
diff --git a/backend/plugins/argocd/tasks/application_extractor.go
b/backend/plugins/argocd/tasks/application_extractor.go
index 33ac3d760..71b81c72b 100644
--- a/backend/plugins/argocd/tasks/application_extractor.go
+++ b/backend/plugins/argocd/tasks/application_extractor.go
@@ -34,6 +34,7 @@ var ExtractApplicationsMeta = plugin.SubTaskMeta{
EntryPoint: ExtractApplications,
EnabledByDefault: true,
Description: "Extract applications from raw data",
+ DomainTypes: []string{plugin.DOMAIN_TYPE_CICD},
DependencyTables: []string{RAW_APPLICATION_TABLE},
ProductTables: []string{models.ArgocdApplication{}.TableName()},
}