klesh commented on PR #9091: URL: https://github.com/apache/devlake/pull/9091#issuecomment-5635194036
> @klesh The intention was to keep this opt-in on the plugin side so existing plugins wouldn’t be forced to implement the new interface just because the framework supports it. > > The idea was that plugins which actually have buffered/stateful resources that need flushing can implement it as needed, while the rest remain unchanged. > > That said, if you’d prefer this PR to include concrete implementations for the existing plugins where it makes sense, I can go through them and add those as part of this PR. Makes sense. Please resolve the conflict and I will merge this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
