lrf-nitro opened a new pull request, #9165:
URL: https://github.com/apache/devlake/pull/9165
The for-loop that cross-compiles libgit2 for aarch64 and x86_64 had no 'set
-e'. If either arch's cmake/make chain failed, the failure was only visible as
a broken '&&' chain within that single loop iteration; the surrounding for-loop
has no error propagation of its own, so it silently moved on to the next arch
and the whole RUN step still exited 0 even though one architecture's libgit2
was never installed under /usr/local/deps. The real failure would then only
surface later, confusingly, in the unrelated 'build' stage as a pkg-config
"libgit2 not found" error when that architecture's (missing) directory was
needed.
Add 'set -e;' to the loop so any future per-arch build failure fails the
image build immediately and visibly, at the point where it actually occurs,
instead of being masked.
No behavior change on the success path: verified both aarch64 and x86_64
libgit2 (with .pc files) are still produced under /usr/local/deps after this
change, building the 'builder' stage natively on an arm64 host.
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [x] I have read through the [Contributing
Documentation](https://devlake.apache.org/community/).
- [x] I have added relevant tests.
- [x] I have added relevant documentation.
- [x] I will add labels to the PR, such as `pr-type/bug-fix`,
`pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
What does this PR do?
### Does this close any open issues?
Closes xx
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
