Thundercloud12 opened a new pull request, #9166:
URL: https://github.com/apache/devlake/pull/9166
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
## Summary
### Problem
In `config-ui/vite.config.ts`, the `/api` dev proxy target was hardcoded to
`http://localhost:8080/`.
When running the backend on a custom port, inside Docker/Dev Containers, or
across remote hosts, developers were required to edit the tracked
`vite.config.ts` file. This caused unnecessary git status noise and introduced
the risk of accidentally committing local development endpoints.
In contrast, the `/grafana` proxy directly below it already supported
dynamic configuration through `VITE_GRAFANA_*` environment variables,
introduced in #8645.
### Solution
Added environment variable support for the `/api` proxy target, following
the existing Grafana configuration pattern:
* `VITE_DEVLAKE_URL` — direct URL override
* `VITE_DEVLAKE_PROTOCOL` — defaults to `http`
* `VITE_DEVLAKE_HOST` — defaults to `localhost`
* `VITE_DEVLAKE_PORT` — defaults to `8080`
Also documented the new `VITE_DEVLAKE_*` variables in
`config-ui/env.example`.
## Does this close any open issues?
Closes `<insert issue number>`
## Screenshots
N/A — Build and development server configuration change.
## Other Information
Verified with:
* `yarn tsc --noEmit`
* `yarn build`
Closes (#9154 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
