DoDiODev opened a new pull request, #9197:
URL: https://github.com/apache/devlake/pull/9197
### Summary
Two small fixes so that Dependabot's `gomod` PRs (first one: #9192) are
actually tested and can turn green:
1. **`fix(ci)`: run unit/e2e tests when `backend/go.mod`, `go.sum` or
`Makefile` change.** The `pull_request.paths` filters of `test.yml` and
`test-e2e.yml` list `go.mod`, `go.sum` and `Makefile` without a directory
prefix. GitHub matches those against the repository root only, so a diff
that touches only `backend/go.mod`/`backend/go.sum` — i.e. every
Dependabot
gomod PR — never triggers `unit-test`, `e2e-mysql` or `e2e-postgres`. On
#9192 only `lint` and a few metadata checks ran; the 26 updates were never
compiled or tested, and the `go mod tidy` guard from #9179 was skipped.
The patterns are now prefixed with `**/` (which also matches the root).
2. **`build(lint)`: tolerate the aws-sdk-go v1 deprecation in the kiro
plugin.** aws-sdk-go v1 is end-of-support since 2025-07-31; its last
release v1.55.8 (pulled in by #9192) marks every package deprecated, so
`staticcheck` reports 11× `SA1019` in `plugins/kiro`. The exclusion is
limited to that check, that import path and that plugin, and carries a
comment to remove it after the migration to aws-sdk-go-v2, which is
tracked
in #9195 and #9196.
No production code changes.
### Does this close any open issues?
No. Unblocks #9192. Related: #9195, #9196.
### Verification
- **Lint, locally** (golangci-lint v2.12.2, `--path-mode=abs` as in CI) on
`upstream/main` + this PR + #9192: **0 issues**. Same tree with the
unchanged `.golangci.yaml`: exactly the 11 `SA1019` findings from the CI
run on #9192.
- **Unit tests, locally** on the same tree: 98 packages `ok`, no failures
(incl. `plugins/kiro/...`); `go mod tidy` on a clean `mocks/` tree leaves
`go.mod`/`go.sum` unchanged.
- **Unmodified upstream workflows in my fork**: base `release-9192-base` =
`upstream/main` + this PR, head = base + the #9192 commit, so the PR diff
touches **only** `backend/go.mod` and `backend/go.sum`
(DoDiODev/devlake#61, closed): **9/9 green** —
[`test
(ubuntu-latest)`](https://github.com/DoDiODev/devlake/actions/runs/37467120462/job/112280846553)
(incl. *Check go.mod is tidy without generated mocks* and *Unit tests*),
[`e2e-mysql`](https://github.com/DoDiODev/devlake/actions/runs/37467120156/job/112280844799),
[`e2e-postgres`](https://github.com/DoDiODev/devlake/actions/runs/37467120156/job/112280844403),
[`lint`](https://github.com/DoDiODev/devlake/actions/runs/37467119275/job/112280841625),
plus the metadata checks. Without fix 1 the first three would not have
been triggered for this diff at all.
### Other Information
I can't exercise the kiro plugin against real AWS resources, so I kept the
code untouched and only made the existing deprecation explicit; the actual
migration is left to the plugin author (see the issues).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
