DoDiODev commented on PR #9192: URL: https://github.com/apache/devlake/pull/9192#issuecomment-6016922993
Thanks, Dependabot — this is the first `gomod` group run since #9179 made `go mod tidy` work on a fresh clone. Two findings: 1. **`lint` is red because of `SA1019`, not because of a real breakage.** `github.com/aws/aws-sdk-go` v1.55.8 is the final release of the end-of-support v1 SDK and marks every package as deprecated; `staticcheck` therefore flags the 11 imports in `plugins/kiro`. The rest of the group is lint-clean. 2. **`unit-test` / `e2e` never ran here.** The `pull_request.paths` filters of `test.yml` and `test-e2e.yml` list `go.mod`/`go.sum`/`Makefile` without a directory prefix, which only matches the repository root, so a `backend/go.mod`-only diff skips them (including the tidy guard from #9179). The green-looking checks above therefore say nothing about whether these 26 updates compile and pass the tests. #9197 fixes both (paths filters → `**/…`, plus a narrowly scoped lint exclusion for the aws-sdk-go v1 deprecation in `plugins/kiro` only). Verified in my fork with the unmodified upstream workflows on `main` + #9197 + this PR's commit (diff = `backend/go.mod`/`go.sum` only): `test`, `e2e-mysql`, `e2e-postgres` and `lint` all green — locally also 98 unit-test packages `ok`. The actual migration away from v1 is tracked in #9195 (kiro → aws-sdk-go-v2) and #9196 (remove v1 from `go.mod`). Once #9197 is merged, a `@dependabot rebase` here should let the full test suite run on this group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
