DoDiODev opened a new pull request, #9210: URL: https://github.com/apache/devlake/pull/9210
### Summary Bump golangci-lint from v2.12.2 to v2.14.0 and adjust the configuration to the newer staticcheck (v0.8.1) it ships. ### Changes | Where | Change | |---|---| | `backend/Makefile` (`go-dep`), `.github/workflows/golangci-lint.yml` | `v2.12.2` → `v2.14.0` | | `backend/.golangci.yaml` | kiro exclusion: staticcheck v0.8.1 reports `SA1019` for `github.com/aws/aws-sdk-go/...` without quotes, so the rule from #9197 now matches both forms | | `backend/.golangci.yaml` | new exclusion for `SA1019: …RawDataSubTaskArgs).Params is deprecated` (see below) | | `plugins/github/tasks/cicd_job_convertor_test.go` | assign the unused `fmt.Sprintf` result in a benchmark helper | | `plugins/jira/e2e/issue_repo_commit_test.go` | keyed `CommitUrlPattern` literals | ### Why exclude `RawDataSubTaskArgs.Params` staticcheck v0.8.1 newly reports 201 uses of the deprecated `RawDataSubTaskArgs.Params` field across about 40 plugins. The field is JSON-encoded into `_raw_data_params` of every raw table and used to find existing raw data. Switching a plugin to `Options` changes that value, so existing raw data would no longer be matched until it is collected again. That is a per-plugin decision, not something to do mechanically in a linter bump. The new rule only matches this one message, so other `SA1019` findings are still reported. It can be removed once the plugins have moved to `Options`. ### Verification | Check | Result | |---|---| | `golangci-lint config verify` (v2.14.0) | ✅ | | golangci-lint v2.14.0 on `backend/`, without issue limits | ✅ 0 issues (201 before the config change) | | golangci-lint v2.12.2 with the new config | ✅ 0 issues | | `go vet` and test compilation of the two changed test packages | ✅ | | Full CI mirror on my fork, with golangci-lint v2.14.0, unit tests and e2e on MySQL and PostgreSQL ([run](https://github.com/DoDiODev/devlake/actions/runs/38251768086)) | ✅ | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
