This is an automated email from the ASF dual-hosted git repository. klesh pushed a commit to branch feat/single-binary in repository https://gitbox.apache.org/repos/asf/devlake.git
commit 2e558fb550f7a00992e54c5b43f930397c93769c Author: Klesh Wong <[email protected]> AuthorDate: Thu Oct 29 15:13:30 2026 +0800 test(e2ehelper): expect qualified primary key column names GetPrimarykeyColumnNames has qualified every column with its table name since 8e915cd59 ("feat: set project mapping by plugin org"), so the result can be dropped into a join condition without colliding with a reserved identifier. Callers that want the bare name strip the prefix themselves (helpers/e2ehelper/data_flow_tester.go:316, and helpers/srvhelper/scope_config_service_helper.go:74 checks the suffix). The test still expected the unqualified names, so it had been failing. It went unnoticed because scripts/unit-test-go.sh filters out every package path matching `e2e`, which covers helpers/e2ehelper; the package needs a live E2E_DB_URL, so it stays out of the DB-less unit-test job. --- backend/helpers/e2ehelper/data_flow_tester_test.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/backend/helpers/e2ehelper/data_flow_tester_test.go b/backend/helpers/e2ehelper/data_flow_tester_test.go index e0490746d..75f3b2023 100644 --- a/backend/helpers/e2ehelper/data_flow_tester_test.go +++ b/backend/helpers/e2ehelper/data_flow_tester_test.go @@ -126,10 +126,14 @@ func TestGetTableMetaData(t *testing.T) { fields, err := dal.GetPrimarykeyColumnNames(dataflowTester.Dal, &TestModel{}) assert.Equal(t, err, nil) assert.Equal(t, 3, len(fields)) + // GetPrimarykeyColumnNames qualifies each column with the table name, so + // the result can be used as-is in join conditions whose column names + // collide with reserved identifiers. Callers that want the bare column + // name strip the prefix themselves. for _, e := range []string{ - "connection_id", - "issue_id", - "label_name", + "_tool_test_model.connection_id", + "_tool_test_model.issue_id", + "_tool_test_model.label_name", } { assert.Contains(t, fields, e) }
