Copilot commented on code in PR #9326: URL: https://github.com/apache/devlake/pull/9326#discussion_r4467308893
########## backend/plugins/all/all_test.go: ########## @@ -0,0 +1,40 @@ +//go:build !devlake_external_plugins + +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package all + +import ( + "testing" + + "github.com/apache/devlake/core/plugin" +) + +// org declares Init and ApiResources on *Org; registering a value would drop its routes. +func TestRegistryKeepsPointerMethods(t *testing.T) { + p, err := plugin.GetPlugin("org") + if err != nil { + t.Fatal(err) + } Review Comment: The generator supports registries that omit `org`, such as `DEVLAKE_PLUGINS=jira,gitlab` and `DEVLAKE_PLUGINS=none`. After regenerating either supported configuration, this test fails at `t.Fatal` even though the registry is correct; the build tag only excludes external-plugin builds, not subset builds. Skip this org-specific check when `org` is not compiled in, while retaining the interface assertions when it is present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
