DoDiODev opened a new pull request, #9339: URL: https://github.com/apache/devlake/pull/9339
### ⚠️ Pre Checklist > Please complete _ALL_ items in this checklist, and remove before submitting - [x] I have read through the [Contributing Documentation](https://devlake.apache.org/community/). - [ ] I have added relevant tests. (N/A: config-only change; the existing golangci-lint job covers it) - [ ] I have added relevant documentation. (N/A) - [x] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc. ### Summary `backend/.golangci.yaml` still carries a staticcheck exclusion that was added in #9197 as a stopgap: ```yaml # aws-sdk-go v1 is end-of-support and its last release marks every # package as deprecated. Tolerate that only for the kiro plugin until it # is migrated to aws-sdk-go-v2; remove this rule afterwards. - linters: - staticcheck path: plugins/kiro/ text: 'SA1019: "?github.com/aws/aws-sdk-go/' ``` The migration it waits for landed in #9233. Since then the backend no longer imports `github.com/aws/aws-sdk-go` (v1) anywhere, and `go.mod` / `go.sum` only contain `aws-sdk-go-v2` modules. The rule now matches nothing. This PR removes it, as its own comment asks. If someone reintroduces a v1 import, golangci-lint reports it again instead of silently ignoring it. ### Does this close any open issues? N/A (follow-up to #9197 and #9233) ### Screenshots N/A ### Other Information - `golangci-lint config verify` passes, and `make mock && make lint` with golangci-lint v2.15.0 (the CI version) reports `0 issues`. - Fork CI on the same change (golangci-lint, unit-test, e2e on MySQL and PostgreSQL, config-ui, license header, Grafana check; 16/16 jobs green): https://github.com/DoDiODev/devlake/actions/runs/42363913171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
