KennethWKZ opened a new pull request, #9408:
URL: https://github.com/apache/devlake/pull/9408

   ### Summary
   
   Five dashboards sit at the root of `grafana/dashboards` but query only the 
MySQL datasource: Claude Code Adoption, Claude Code Adoption by User, 
incident.io, Linear and Rootly. Because they are at the root, the 
`devlake-dashboard` image provisions them in both database modes, so a 
PostgreSQL deployment shows them as broken dashboards.
   
   This PR moves them to `grafana/dashboards/mysql`, where the entrypoint 
already keeps only the folder for the configured database. Their content is 
unchanged.
   
   It also extends `grafana/scripts/smoke-test.sh`: the test now fails when a 
provisioned dashboard points at the other database's datasource, so a dashboard 
added at the root for one database is caught in CI.
   
   ### Does this close any open issues?
   
   No open issue. Found on a PostgreSQL deployment: incident.io was provisioned 
and broken (its datasource is written as plain `mysql`), and the other four 
only stayed out because of a local workaround.
   
   ### Screenshots
   
   Not applicable (file moves and a test change).
   
   ### Other Information
   
   Tested:
   - `grafana/scripts/smoke-test.sh` passes in PostgreSQL mode and in MySQL 
mode with the moved files.
   - With one of the dashboards moved back to the root, the PostgreSQL run 
fails with `dashboards for another database are provisioned in postgresql mode: 
/etc/grafana/dashboards/Linear.json`.
   - On a running PostgreSQL deployment with the rebuilt image: Grafana 
healthy, none of the five dashboards provisioned, all remaining dashboards load 
against the PostgreSQL datasource.
   
   Suggested label: `pr-type/bug-fix`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to