[
https://issues.apache.org/jira/browse/DL-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802375#comment-15802375
]
ASF GitHub Bot commented on DL-171:
-----------------------------------
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/98
looks good to me. it is okay for a short term fix. moving forward, we might
consider how to improve the test in general to make them time independent.
+1
> TestAppendOnlyStreamWriter#testPositionUpdatesOnlyAfterWriteCompletionWithoutFsync
> failed occasionally
> ------------------------------------------------------------------------------------------------------
>
> Key: DL-171
> URL: https://issues.apache.org/jira/browse/DL-171
> Project: DistributedLog
> Issue Type: Bug
> Components: tests
> Affects Versions: 0.4.0
> Reporter: Liang Xie
> Assignee: Liang Xie
>
> I had seen several failed running, i.g. the latest one:
> https://builds.apache.org/job/distributedlog-precommit-pullrequest/68/com.twitter$distributedlog-core/testReport/com.twitter.distributedlog/TestAppendOnlyStreamWriter/testPositionUpdatesOnlyAfterWriteCompletionWithoutFsync/
> I can reproduce it after several runnings locally, after diving into the
> detail, it turn out that an execution sequence issue: once the "writer.write"
> be done, if "writer.position()" be invoked easier than the
> WriteCompleteListener onSuccess callback, due to the "synchronized", the
> position result will be 0, not the expected 33. we can just add a short sleep
> to avoid this test issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
