[
https://issues.apache.org/jira/browse/DL-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15803278#comment-15803278
]
ASF GitHub Bot commented on DL-173:
-----------------------------------
GitHub user adamtracymartin opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/103
DL-173: changed FileUtils.deleteDirectory to FileUtils.forceDeleteOnExit so
directory will delete on Windows.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adamtracymartin/incubator-distributedlog
DL-173
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit db04e15ef18ce27fe240303d3325127941e99aec
Author: adamtracymartin <[email protected]>
Date: 2017-01-05T21:05:48Z
changed // comments to /* */
commit 2783d26325378def9c8d4f77de1a3498709dfcc4
Author: adamtracymartin <[email protected]>
Date: 2017-01-06T02:28:41Z
changed FileUtils.deleteDirectory to FileUtils.forceDeleteOnExit so
directory will delete on Windows.
----
> Test fail on Windows - Unable to delete directory
> -------------------------------------------------
>
> Key: DL-173
> URL: https://issues.apache.org/jira/browse/DL-173
> Project: DistributedLog
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Tracy Martin
> Assignee: Tracy Martin
> Priority: Minor
>
> When running "mvn clean test", some of the tests fail because a directory
> cannot be deleted.
> An example:
> java.io.IOException: Unable to delete file:
> C:\Users\TRACYM~1\AppData\Local\Temp\zookeeper6811260662521660350com.twitter.distributedlog.ZooKeeperClusterTestCase\version-2\log.1
> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1919)
> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1399)
> at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1331)
> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1910)
> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1399)
> at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1331)
> at
> com.twitter.distributedlog.ZooKeeperClusterTestCase.shutdownZooKeeper(ZooKeeperClusterTestCase.java:50)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:37)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> at
> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
> at
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
> at
> org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:172)
> at
> org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcessWhenForked(SurefireStarter.java:78)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:70)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
