[ 
https://issues.apache.org/jira/browse/DL-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-173.
--------------------------
       Resolution: Fixed
    Fix Version/s: 0.4.0

Issue resolved by merging pull request 116
      [https://github.com/apache/incubator-distributedlog/pull/116]

      {noformat}
      commit 06ab8216295ea25403534cf9c3b3e1db5683cb77
Author:     adamtracymartin <[email protected]>
AuthorDate: Wed Apr 12 21:36:19 2017 -0700
Commit:     Sijie Guo <[email protected]>
CommitDate: Wed Apr 12 21:36:19 2017 -0700

    DL-173: changed FileUtils.deleteDirectory to FileUtils.forceDeleteOnExit so 
d…
    
    I am doing a new pull request because I deleted the branch in the remote.
    Actions done to fix the conflict.
    1. git checkout DL-173
    2. git checkout master 
distributedlog-protocol/src/main/thrift/service.thrift
    3. git fetch
    4. git add *
    5. git commit with message
    
    The actual fix for this branch is changing FileUtils.deleteDirectory to 
FileUtils.forceDeleteOnExit.
    
    Author: adamtracymartin <[email protected]>
    
    Reviewers: Jia Zhai <[email protected]>, Sijie Guo <[email protected]>, 
Leigh Stewart <[email protected]>
    
    Closes #116 from adamtracymartin/DL-173

      {noformat}
      

> Test fail on Windows - Unable to delete directory
> -------------------------------------------------
>
>                 Key: DL-173
>                 URL: https://issues.apache.org/jira/browse/DL-173
>             Project: DistributedLog
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Tracy Martin
>            Assignee: Tracy Martin
>            Priority: Minor
>             Fix For: 0.4.0
>
>
> When running "mvn clean test", some of the tests fail because a directory 
> cannot be deleted.  
> An example:
> java.io.IOException: Unable to delete file: 
> C:\Users\TRACYM~1\AppData\Local\Temp\zookeeper6811260662521660350com.twitter.distributedlog.ZooKeeperClusterTestCase\version-2\log.1
>       at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1919)
>       at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1399)
>       at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1331)
>       at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1910)
>       at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1399)
>       at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1331)
>       at 
> com.twitter.distributedlog.ZooKeeperClusterTestCase.shutdownZooKeeper(ZooKeeperClusterTestCase.java:50)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
>       at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:37)
>       at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
>       at 
> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
>       at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
>       at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
>       at 
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
>       at 
> org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:172)
>       at 
> org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcessWhenForked(SurefireStarter.java:78)
>       at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:70)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to