[
https://issues.apache.org/jira/browse/DL-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035936#comment-16035936
]
ASF GitHub Bot commented on DL-124:
-----------------------------------
Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984676
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKLogWriteHandler.java
---
@@ -483,23 +482,23 @@ protected long assignLogSegmentSequenceNumber()
throws IOException {
}
protected BKLogSegmentWriter doStartLogSegment(long txId, boolean
bestEffort, boolean allowMaxTxID) throws IOException {
- return FutureUtils.result(asyncStartLogSegment(txId, bestEffort,
allowMaxTxID));
+ return Utils.ioResult(asyncStartLogSegment(txId, bestEffort,
allowMaxTxID));
}
- protected Future<BKLogSegmentWriter> asyncStartLogSegment(final long
txId,
+ protected CompletableFuture<BKLogSegmentWriter>
asyncStartLogSegment(final long txId,
final
boolean bestEffort,
--- End diff --
Please also do the code alignment change here.
> Use Java8 Future rather than twitter Future
> -------------------------------------------
>
> Key: DL-124
> URL: https://issues.apache.org/jira/browse/DL-124
> Project: DistributedLog
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Gerrit Sundaram
> Assignee: Sijie Guo
> Labels: help-wanted
> Fix For: 0.5.0
>
>
> Since it is written in java, it would be good to leverage java8 future rather
> than introducing dependencies on scala.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
