[
https://issues.apache.org/jira/browse/DL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046148#comment-16046148
]
ASF GitHub Bot commented on DL-205:
-----------------------------------
Github user leighst commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/131
looks good. i guess the choice here is to make it like bk, to some extent.
personally i think having a pojo StatusCode object would be better than
passing around ints which can be easily misinterpreted. but i dont have a
strong opinion.
> Remove StatusCode dependency on DLException
> -------------------------------------------
>
> Key: DL-205
> URL: https://issues.apache.org/jira/browse/DL-205
> Project: DistributedLog
> Issue Type: Task
> Affects Versions: 0.4.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 0.5.0
>
>
> Currently DLException (and its sub-classes) are using the generated
> StatusCode as the exception code. It causes distributedlog-core unfortunately
> depend on libthrift 0.5.0 and scrooge.
> This change is to remove the StatusCode dependency.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
