[
https://issues.apache.org/jira/browse/DL-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053393#comment-16053393
]
ASF GitHub Bot commented on DL-124:
-----------------------------------
Github user sijie commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r122609664
--- Diff: distributedlog-benchmark/conf/log4j.properties ---
@@ -30,11 +30,7 @@ log4j.logger.org.apache.zookeeper=INFO
log4j.logger.org.apache.bookkeeper=INFO
# redirect executor output to executors.log since slow op warnings can be
quite verbose
-log4j.logger.org.apache.distributedlog.util.MonitoredFuturePool=INFO,
Executors
-log4j.logger.org.apache.distributedlog.util.MonitoredScheduledThreadPoolExecutor=INFO,
Executors
log4j.logger.org.apache.bookkeeper.util.SafeRunnable=INFO, Executors
-log4j.additivity.org.apache.distributedlog.util.MonitoredFuturePool=false
--- End diff --
MonitoredFuturePool and MonitoredScheduledThreadPoolExecutor are already
removed in this patch. because in Java8, you can configure a thread where the
callbacks will be executed, there is no need for additional future pool, we
just use the ordered scheduler.
> Use Java8 Future rather than twitter Future
> -------------------------------------------
>
> Key: DL-124
> URL: https://issues.apache.org/jira/browse/DL-124
> Project: DistributedLog
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Gerrit Sundaram
> Assignee: Sijie Guo
> Labels: help-wanted
> Fix For: 0.5.0
>
>
> Since it is written in java, it would be good to leverage java8 future rather
> than introducing dependencies on scala.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
